Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): empty formular bar when in array range #1532

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 9, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1255

Copy link

github-actions bot commented Mar 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 32.78%. Comparing base (473cf6f) to head (f8ec757).

Files Patch % Lines
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 3 Missing ⚠️
...rc/controllers/editor/formula-editor.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1532   +/-   ##
=======================================
  Coverage   32.78%   32.78%           
=======================================
  Files         913      913           
  Lines       50804    50804           
  Branches    10591    10592    +1     
=======================================
  Hits        16656    16656           
  Misses      34148    34148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review March 9, 2024 05:16
@Jocs Jocs requested review from Dushusir and DR-Univer March 9, 2024 05:16
@DR-Univer DR-Univer merged commit eea95ac into dev Mar 9, 2024
7 checks passed
@DR-Univer DR-Univer deleted the feat/empty-formula-bar branch March 9, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] [Fx editor] 数组公式编辑应为空
3 participants